Unionfs: remove unnecessary lock in read_inode
authorErez Zadok <ezk@cs.sunysb.edu>
Fri, 21 Dec 2007 04:14:44 +0000 (23:14 -0500)
committerErez Zadok <ezk@cs.sunysb.edu>
Fri, 12 Aug 2011 02:37:16 +0000 (22:37 -0400)
Our read_inode doesn't need to grab the superblock rwsem because there no
chance it could be affected by branch management.  But our read_inode was
called from other places which did grab need to grab that rwsem, and lockdep
complained.

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
fs/unionfs/super.c

index c474c8624b6293f4d0669f6cfed661dd60351d8d..8b70acab741eb54476d6874bed8d692b3afff394 100644 (file)
@@ -29,8 +29,6 @@ static void unionfs_read_inode(struct inode *inode)
        int size;
        struct unionfs_inode_info *info = UNIONFS_I(inode);
 
-       unionfs_read_lock(inode->i_sb);
-
        memset(info, 0, offsetof(struct unionfs_inode_info, vfs_inode));
        info->bstart = -1;
        info->bend = -1;
@@ -63,7 +61,6 @@ static void unionfs_read_inode(struct inode *inode)
        inode->i_mtime.tv_sec = inode->i_mtime.tv_nsec = 0;
        inode->i_ctime.tv_sec = inode->i_ctime.tv_nsec = 0;
 
-       unionfs_read_unlock(inode->i_sb);
 }
 
 /*