Unionfs: remove unnecessary lock when deleting whiteouts
authorErez Zadok <ezk@cs.sunysb.edu>
Fri, 21 Dec 2007 04:10:19 +0000 (23:10 -0500)
committerErez Zadok <ezk@cs.sunysb.edu>
Fri, 29 Apr 2011 02:25:36 +0000 (22:25 -0400)
Lockdep complained, because we eventually call vfs_unlink which'd grab the
necessary locks.

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
fs/unionfs/dirhelper.c

index 2e52fc3a1622315a54795ff99c632581856ebe51..b40090a403929e89c59451e17713ec13bf288e67 100644 (file)
@@ -110,7 +110,6 @@ int delete_whiteouts(struct dentry *dentry, int bindex,
        lower_dir = lower_dir_dentry->d_inode;
        BUG_ON(!S_ISDIR(lower_dir->i_mode));
 
-       mutex_lock(&lower_dir->i_mutex);
        if (!permission(lower_dir, MAY_WRITE | MAY_EXEC, NULL)) {
                err = do_delete_whiteouts(dentry, bindex, namelist);
        } else {
@@ -120,7 +119,6 @@ int delete_whiteouts(struct dentry *dentry, int bindex,
                run_sioq(__delete_whiteouts, &args);
                err = args.err;
        }
-       mutex_unlock(&lower_dir->i_mutex);
 
 out:
        return err;