From: Joe Thornber Date: Tue, 6 May 2014 15:28:14 +0000 (+0100) Subject: dm thin: allow metadata commit if pool is in PM_OUT_OF_DATA_SPACE mode X-Git-Tag: v3.14.6~46 X-Git-Url: https://git.fsl.cs.sunysb.edu/?a=commitdiff_plain;h=36f7757dadcd45c0ecce396662f923c0841e12ff;p=unionfs-2.6.30.y.git dm thin: allow metadata commit if pool is in PM_OUT_OF_DATA_SPACE mode commit 8d07e8a5f5bc7b90f755d9b427ea930024f4c986 upstream. Commit 3e1a0699 ("dm thin: fix out of data space handling") introduced a regression in the metadata commit() method by returning an error if the pool is in PM_OUT_OF_DATA_SPACE mode. This oversight caused a thin device to return errors even if the default queue_if_no_space ENOSPC handling mode is used. Fix commit() to only fail if pool is in PM_READ_ONLY or PM_FAIL mode. Reported-by: qindehua@163.com Signed-off-by: Joe Thornber Signed-off-by: Mike Snitzer Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index 60cc50685c1..ec93a19d912 100644 --- a/drivers/md/dm-thin.c +++ b/drivers/md/dm-thin.c @@ -920,7 +920,7 @@ static int commit(struct pool *pool) { int r; - if (get_pool_mode(pool) != PM_WRITE) + if (get_pool_mode(pool) >= PM_READ_ONLY) return -EINVAL; r = dm_pool_commit_metadata(pool->pmd);