From: Erez Zadok Date: Sat, 24 Nov 2007 21:03:14 +0000 (-0500) Subject: Unionfs: update times in setattr X-Git-Tag: unionfs-2.1.10~6 X-Git-Url: https://git.fsl.cs.sunysb.edu/?a=commitdiff_plain;h=47a0595102bc76374ff6e5fc06b1de7ed02558bd;p=unionfs-2.6.31.y.git Unionfs: update times in setattr Needed to maintain Unix semantics via utimes(2). Signed-off-by: Erez Zadok --- diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index ef61d9c533d..63ff3d3ebeb 100644 --- a/fs/unionfs/inode.c +++ b/fs/unionfs/inode.c @@ -1090,6 +1090,18 @@ static int unionfs_setattr(struct dentry *dentry, struct iattr *ia) /* get the size from the first lower inode */ lower_inode = unionfs_lower_inode(inode); unionfs_copy_attr_all(inode, lower_inode); + /* + * unionfs_copy_attr_all will copy the lower times to our inode if + * the lower ones are newer (useful for cache coherency). However, + * ->setattr is the only place in which we may have to copy the + * lower inode times absolutely, to support utimes(2). + */ + if (ia->ia_valid & ATTR_MTIME_SET) + inode->i_mtime = lower_inode->i_mtime; + if (ia->ia_valid & ATTR_CTIME) + inode->i_ctime = lower_inode->i_ctime; + if (ia->ia_valid & ATTR_ATIME_SET) + inode->i_atime = lower_inode->i_atime; fsstack_copy_inode_size(inode, lower_inode); /* if setattr succeeded, then parent dir may have changed */ unionfs_copy_attr_times(dentry->d_parent->d_inode);