From: Erez Zadok Date: Tue, 12 Aug 2014 02:42:49 +0000 (-0400) Subject: Unionfs: fix d_revalidate for corner case X-Git-Url: https://git.fsl.cs.sunysb.edu/?a=commitdiff_plain;h=51831f0511b104e3be2f99d0ada6808016126725;p=unionfs-2.6.20.y.git Unionfs: fix d_revalidate for corner case In some cases, lower_dentry may goes to NULL. Return 0 here to mark it as invalid dentry. Signed-off-by: Erez Zadok Signed-off-by: Mengyang Li --- diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index b8bdc0c6c6a..257022bfb4c 100644 --- a/fs/unionfs/dentry.c +++ b/fs/unionfs/dentry.c @@ -308,6 +308,11 @@ static int unionfs_d_revalidate(struct dentry *dentry, parent = unionfs_lock_parent(dentry, UNIONFS_DMUTEX_PARENT); unionfs_lock_dentry(dentry, UNIONFS_DMUTEX_CHILD); + if (!unionfs_lower_dentry(dentry)) { + err = 0; + goto out; + } + valid = __unionfs_d_revalidate(dentry, parent, false); if (valid) { unionfs_postcopyup_setmnt(dentry); @@ -316,6 +321,7 @@ static int unionfs_d_revalidate(struct dentry *dentry, d_drop(dentry); err = valid; } +out: unionfs_unlock_dentry(dentry); unionfs_unlock_parent(dentry, parent); unionfs_read_unlock(dentry->d_sb);