From: Vasily Tarasov Date: Mon, 6 Apr 2015 14:38:56 +0000 (-0400) Subject: For consistency set error msg fist then set error code X-Git-Url: https://git.fsl.cs.sunysb.edu/?a=commitdiff_plain;h=534351ef6ff0723602348406c78afd5bee05e598;p=linux-dmdedup.git For consistency set error msg fist then set error code --- diff --git a/drivers/md/dm-dedup-target.c b/drivers/md/dm-dedup-target.c index a49faadc831..e58f6476aa5 100644 --- a/drivers/md/dm-dedup-target.c +++ b/drivers/md/dm-dedup-target.c @@ -634,15 +634,15 @@ static int dm_dedup_ctr(struct dm_target *ti, unsigned int argc, char **argv) dedup_work_pool = mempool_create_kmalloc_pool(MIN_DEDUP_WORK_IO, sizeof(struct dedup_work)); if (!dedup_work_pool) { - r = -ENOMEM; ti->error = "failed to create mempool"; + r = -ENOMEM; goto bad_mempool; } dc->io_client = dm_io_client_create(); if (IS_ERR(dc->io_client)) { - r = PTR_ERR(dc->io_client); ti->error = "failed to create dm_io_client"; + r = PTR_ERR(dc->io_client); goto bad_io_client; } @@ -692,8 +692,8 @@ static int dm_dedup_ctr(struct dm_target *ti, unsigned int argc, char **argv) sizeof(struct hash_pbn_value), dc->pblocks, unformatted); if (IS_ERR(dc->kvs_hash_pbn)) { - r = PTR_ERR(dc->kvs_hash_pbn); ti->error = "failed to create sparse KVS"; + r = PTR_ERR(dc->kvs_hash_pbn); goto bad_kvstore_init; }