From: Johan Hovold <jhovold@gmail.com>
Date: Tue, 10 Sep 2013 10:50:49 +0000 (+0200)
Subject: serial: pch_uart: fix tty-kref leak in rx-error path
X-Git-Tag: v3.11.4~37
X-Git-Url: https://git.fsl.cs.sunysb.edu/?a=commitdiff_plain;h=7c429067c4df70216638104c890bf6cfe4fdcf95;p=unionfs-2.6.39.y.git

serial: pch_uart: fix tty-kref leak in rx-error path

commit fc0919c68cb2f75bb1af759315f9d7e2a9443c28 upstream.

Fix tty-kref leak introduced by commit 384e301e ("pch_uart: fix a
deadlock when pch_uart as console") which never put its tty reference.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
index 572d48189de..591cadb0bcc 100644
--- a/drivers/tty/serial/pch_uart.c
+++ b/drivers/tty/serial/pch_uart.c
@@ -1071,6 +1071,8 @@ static void pch_uart_err_ir(struct eg20t_port *priv, unsigned int lsr)
 	if (tty == NULL) {
 		for (i = 0; error_msg[i] != NULL; i++)
 			dev_err(&priv->pdev->dev, error_msg[i]);
+	} else {
+		tty_kref_put(tty);
 	}
 }