From: Jeff Layton <jlayton@kernel.org>
Date: Thu, 12 Nov 2020 14:37:59 +0000 (-0500)
Subject: ceph: fix inode refcount leak when ceph_fill_inode on non-I_NEW inode fails
X-Git-Tag: v5.10.5~9
X-Git-Url: https://git.fsl.cs.sunysb.edu/?a=commitdiff_plain;h=86be0f2a0ef9d85e4872d4017b09e4e620d948ae;p=wrapfs-5.3.y.git

ceph: fix inode refcount leak when ceph_fill_inode on non-I_NEW inode fails

[ Upstream commit 68cbb8056a4c24c6a38ad2b79e0a9764b235e8fa ]

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
index 526faf4778ce..2462a9a84b95 100644
--- a/fs/ceph/inode.c
+++ b/fs/ceph/inode.c
@@ -1335,6 +1335,8 @@ int ceph_fill_trace(struct super_block *sb, struct ceph_mds_request *req)
 				in, ceph_vinop(in));
 			if (in->i_state & I_NEW)
 				discard_new_inode(in);
+			else
+				iput(in);
 			goto done;
 		}
 		req->r_target_inode = in;