From: Alan Cox Date: Tue, 4 Sep 2012 14:10:08 +0000 (+0100) Subject: dj: memory scribble in logi_dj X-Git-Tag: v3.4.92~6 X-Git-Url: https://git.fsl.cs.sunysb.edu/?a=commitdiff_plain;h=a592e24417be6e6f7e31d89e1e88c1c5999771bd;p=unionfs-2.6.39.y.git dj: memory scribble in logi_dj commit 8a55ade76551e3927b4e41ee9e7751875d18bc25 upstream. Allocate a structure not a pointer to it ! Signed-off-by: Alan Cox Signed-off-by: Linus Torvalds Cc: Yijing Wang Cc: Marc Dionne Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index 7f861bedc72..3bfd74f1ad4 100644 --- a/drivers/hid/hid-logitech-dj.c +++ b/drivers/hid/hid-logitech-dj.c @@ -477,7 +477,7 @@ static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev) struct dj_report *dj_report; int retval; - dj_report = kzalloc(sizeof(dj_report), GFP_KERNEL); + dj_report = kzalloc(sizeof(struct dj_report), GFP_KERNEL); if (!dj_report) return -ENOMEM; dj_report->report_id = REPORT_ID_DJ_SHORT; @@ -495,7 +495,7 @@ static int logi_dj_recv_switch_to_dj_mode(struct dj_receiver_dev *djrcv_dev, struct dj_report *dj_report; int retval; - dj_report = kzalloc(sizeof(dj_report), GFP_KERNEL); + dj_report = kzalloc(sizeof(struct dj_report), GFP_KERNEL); if (!dj_report) return -ENOMEM; dj_report->report_id = REPORT_ID_DJ_SHORT;