From: Erez Zadok Date: Thu, 10 Jan 2008 11:59:57 +0000 (-0500) Subject: Unionfs: remove unnecessary lock in read_inode X-Git-Url: https://git.fsl.cs.sunysb.edu/?a=commitdiff_plain;h=ac70a9331a32a3406c6c6353f50ddf5e84234d37;p=unionfs-odf.git Unionfs: remove unnecessary lock in read_inode Our read_inode doesn't need to grab the superblock rwsem because there no chance it could be affected by branch management. But our read_inode was called from other places which did grab need to grab that rwsem, and lockdep complained. Signed-off-by: Erez Zadok --- diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c index 8fdf7ab4fc..5df95d5166 100644 --- a/fs/unionfs/super.c +++ b/fs/unionfs/super.c @@ -29,8 +29,6 @@ static void unionfs_read_inode(struct inode *inode) int size; struct unionfs_inode_info *info = UNIONFS_I(inode); - unionfs_read_lock(inode->i_sb); - memset(info, 0, offsetof(struct unionfs_inode_info, vfs_inode)); info->bstart = -1; info->bend = -1; @@ -61,7 +59,6 @@ static void unionfs_read_inode(struct inode *inode) inode->i_mtime.tv_sec = inode->i_mtime.tv_nsec = 0; inode->i_ctime.tv_sec = inode->i_ctime.tv_nsec = 0; - unionfs_read_unlock(inode->i_sb); } /*