From: Jiri Slaby <jslaby@suse.cz>
Date: Mon, 28 Feb 2011 09:34:06 +0000 (+0100)
Subject: USB: serial/kobil_sct, fix potential tty NULL dereference
X-Git-Tag: v2.6.34.10~69
X-Git-Url: https://git.fsl.cs.sunysb.edu/?a=commitdiff_plain;h=d79559a7a4ae3980f2199e1f5d16acb7714bf258;p=unionfs-2.6.25.y.git

USB: serial/kobil_sct, fix potential tty NULL dereference

commit 6960f40a954619857e7095a6179eef896f297077 upstream.

Make sure that we check the return value of tty_port_tty_get.
Sometimes it may return NULL and we later dereference that.

The only place here is in kobil_read_int_callback, so fix it.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---

diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
index bd5bd8589e0..b382d9a0274 100644
--- a/drivers/usb/serial/kobil_sct.c
+++ b/drivers/usb/serial/kobil_sct.c
@@ -372,7 +372,7 @@ static void kobil_read_int_callback(struct urb *urb)
 	}
 
 	tty = tty_port_tty_get(&port->port);
-	if (urb->actual_length) {
+	if (tty && urb->actual_length) {
 
 		/* BEGIN DEBUG */
 		/*