From: Li RongQing <roy.qing.li@gmail.com>
Date: Thu, 22 May 2014 08:36:55 +0000 (+0800)
Subject: ipv4: initialise the itag variable in __mkroute_input
X-Git-Tag: v3.12.21~2
X-Git-Url: https://git.fsl.cs.sunysb.edu/?a=commitdiff_plain;h=ee08bba5f0f2c32f12a465542ad4b6a42c4a1417;p=unionfs-2.6.25.y.git

ipv4: initialise the itag variable in __mkroute_input

[ Upstream commit fbdc0ad095c0a299e9abf5d8ac8f58374951149a ]

the value of itag is a random value from stack, and may not be initiated by
fib_validate_source, which called fib_combine_itag if CONFIG_IP_ROUTE_CLASSID
is not set

This will make the cached dst uncertainty

Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---

diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index ae8aadbbb3c..2b681867164 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -1525,7 +1525,7 @@ static int __mkroute_input(struct sk_buff *skb,
 	struct in_device *out_dev;
 	unsigned int flags = 0;
 	bool do_cache;
-	u32 itag;
+	u32 itag = 0;
 
 	/* get a working reference to the output device */
 	out_dev = __in_dev_get_rcu(FIB_RES_DEV(*res));