From: Erez_Zadok <ezk@cs.sunysb.edu>
Date: Fri, 25 May 2007 19:47:44 +0000 (-0400)
Subject: unionfs: minor cleanup and better commenting in new_dentry_private_data
X-Git-Url: https://git.fsl.cs.sunysb.edu/?a=commitdiff_plain;h=f6fff5aeee27ca0961a54d660032481083528125;p=unionfs-3.15.y.git

unionfs: minor cleanup and better commenting in new_dentry_private_data

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
---

diff --git a/fs/unionfs/lookup.c b/fs/unionfs/lookup.c
index 0593f569186..ffc00446ce6 100644
--- a/fs/unionfs/lookup.c
+++ b/fs/unionfs/lookup.c
@@ -458,7 +458,10 @@ void free_dentry_private_data(struct unionfs_dentry_info *udi)
 	kmem_cache_free(unionfs_dentry_cachep, udi);
 }
 
-/* allocate new dentry private data, free old one if necessary */
+/*
+ * Allocate new dentry private data, free old one if necessary.
+ * On success, returns a dentry whose ->info node is locked already.
+ */
 int new_dentry_private_data(struct dentry *dentry)
 {
 	int size;
@@ -476,9 +479,7 @@ int new_dentry_private_data(struct dentry *dentry)
 
 	mutex_lock(&info->lock);
 
-	info->bstart = -1;
-	info->bend = -1;
-	info->bopaque = -1;
+	info->bstart = info->bend = info->bopaque = -1;
 	info->bcount = sbmax(dentry->d_sb);
 	atomic_set(&info->generation,
 		   atomic_read(&UNIONFS_SB(dentry->d_sb)->generation));