From: Erez_Zadok <ezk@cs.sunysb.edu>
Date: Fri, 25 May 2007 21:01:00 +0000 (-0400)
Subject: bug fix: catch bad use of dirs= options (extra ':' separators)
X-Git-Tag: unionfs-2.5.9.2~389
X-Git-Url: https://git.fsl.cs.sunysb.edu/?a=commitdiff_plain;h=f91757bf207988906f04cd554076c3a52a77f435;p=unionfs-2.6.38.y.git

bug fix: catch bad use of dirs= options (extra ':' separators)

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
---

diff --git a/fs/unionfs/main.c b/fs/unionfs/main.c
index decefef3c72..a690182da5e 100644
--- a/fs/unionfs/main.c
+++ b/fs/unionfs/main.c
@@ -320,8 +320,12 @@ static int parse_dirs_option(struct super_block *sb, struct unionfs_dentry_info
 		int perms;
 		char *mode = strchr(name, '=');
 
-		if (!name || !*name)
+		if (!name)
 			continue;
+		if (!*name) {	/* bad use of ':' (extra colons) */
+			err = -EINVAL;
+			goto out;
+		}
 
 		branches++;