From 2d6eac6c4fdaa69656d66c80754d267be233cc3f Mon Sep 17 00:00:00 2001 From: Adrian Bunk Date: Mon, 28 Nov 2005 12:46:00 +0100 Subject: [PATCH] [PATCH] drivers/infiniband/core/mad.c: fix a use-after-free The Coverity checker spotted this obvious use-after-free caused by a wrong order of the cleanups. Signed-off-by: Adrian Bunk Acked-by: Roland Dreier Signed-off-by: Chris Wright Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/core/mad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c index a14ca87fda1..96855fceb25 100644 --- a/drivers/infiniband/core/mad.c +++ b/drivers/infiniband/core/mad.c @@ -356,9 +356,9 @@ error4: spin_unlock_irqrestore(&port_priv->reg_lock, flags); kfree(reg_req); error3: - kfree(mad_agent_priv); -error2: ib_dereg_mr(mad_agent_priv->agent.mr); +error2: + kfree(mad_agent_priv); error1: return ret; } -- 2.34.1