From 82acbf70edbec2fff30d1b6c090f1f9c0909e093 Mon Sep 17 00:00:00 2001
From: zoulasc <christos@zoulas.com>
Date: Wed, 26 Mar 2014 15:58:28 -0400
Subject: [PATCH] partially from Ian Kent: use mktemp for better security.

---
 scripts/fixrmtab.in | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/scripts/fixrmtab.in b/scripts/fixrmtab.in
index 23003806..8f57e31d 100755
--- a/scripts/fixrmtab.in
+++ b/scripts/fixrmtab.in
@@ -10,15 +10,19 @@
 
 #set -x
 
-RMTAB=/etc/rmtab
-TMP=/tmp/rmtab.$$
-
-if [ ! -f /etc/rmtab ]; then
+if [ ! -f "$RMTAB" ]; then
 	exit 0
 fi
 
-for host in $*
+RMTAB=/etc/rmtab
+TMP="$(mktemp ${RMTAB}.XXXXXX)"
+if [ -z "$TMP" ]; then
+	exit 1
+fi
+
+trap "rm -f $TMP" 0 1 2 3 15
+
+for host
 do
-	sed -e '/^'$host':/s/^./#/' $RMTAB > $TMP && cp $TMP $RMTAB
+	sed -e "/^$host:/s/^./#/" "$RMTAB" > "$TMP" && cp "$TMP" "$RMTAB"
 done
-rm -f $TMP
-- 
2.34.1