From f3f13f0205ec3983887407de0a3317ad4c7b4067 Mon Sep 17 00:00:00 2001 From: Erez Zadok Date: Fri, 25 Jan 2008 20:21:07 -0500 Subject: [PATCH] Unionfs: remove unnecessary call to d_iput This old code was to fix a bug which has long since been fixed in our copyup_permission and unionfs_d_iput. Signed-off-by: Erez Zadok --- fs/unionfs/copyup.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c index b22d23c644d..b028908021b 100644 --- a/fs/unionfs/copyup.c +++ b/fs/unionfs/copyup.c @@ -801,19 +801,6 @@ begin: lower_dentry); unlock_dir(lower_parent_dentry); if (err) { - struct inode *inode = lower_dentry->d_inode; - /* - * If we get here, it means that we created a new - * dentry+inode, but copying permissions failed. - * Therefore, we should delete this inode and dput - * the dentry so as not to leave cruft behind. - */ - if (lower_dentry->d_op && lower_dentry->d_op->d_iput) - lower_dentry->d_op->d_iput(lower_dentry, - inode); - else - iput(inode); - lower_dentry->d_inode = NULL; dput(lower_dentry); lower_dentry = ERR_PTR(err); goto out; -- 2.43.0